Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gauche-gtk - Gauche extension module to use GTK https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188176 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-05-06 15:11 EST ------- OK, now we're getting somewhere. Rawhide still looks broken to me, but builds in FC5, i386 and x86_64 succeed and I ran through the examples on x86_64 with no problems. rpmlint has a couple of complaints: W: gauche-gtk hidden-file-or-dir /usr/share/gauche/0.8.7/lib/.packages W: gauche-gtk hidden-file-or-dir /usr/share/gauche/0.8.7/lib/.packages W: gauche-gtk doc-file-dependency /usr/share/doc/gauche-gtk-0.4.1/examples/glgd/run /bin/sh The problem with the first warning is that it will set off various rootkit detection programs and is generally a bad idea, but I'm not sure if it would be feasible to change where gauche looks for its packages. I'm inclined to say this isn't a blocker, but if it's not difficult to make gauche look in "packages" instead of ".packages" then I think it would be best if you could do so. The second is simply that the doc file is executable, which is generally considered a bad idea although in this case the dependency doesn't cause problems. I would suggest that you just chmod -x examples/glgd/run. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * license field matches the actual license. * license is open source-compatible; text is included in the package. * source files match upstream: 18356efab446b9524be8371a3b852a6a Gauche-gtk-0.4.1.tgz 18356efab446b9524be8371a3b852a6a Gauche-gtk-0.4.1.tgz-srpm * latest version is being packaged. * BuildRequires are proper. * package builds in mock (FC5, i386 and x86_64). O rpmlint has excusable errors. * final provides and requires are sane. O shared libraries are present, but they are internal to Gauche and so ldconfig doesn't need to be called. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. O file permissions are appropriate, exceot for an executable docfile. * %clean is present. O %check is not present; no test suite upstream. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. APPROVED, but please consider the two issues above before checking in. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review