Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-ppp - A GNOME 2 WvDial frontend https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190873 mpeters@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From mpeters@xxxxxxx 2006-05-06 02:02 EST ------- Good: * md5sum matches upstream: ec2e20fc713a01c953d759bea3df8618 gnome-ppp-0.3.23.tar.bz2 * Package appropriately named (matches upstream) * spec file matches src.rpm name * Package meets package guidelines * Appropriate License (GPL), matches COPYING file, in %doc * Spec file written in legible American English * Succesfully builds in FC5 i386 mock * locales handled properly * no shared libs to fuss over * not relocatable * owns every directory it creates * no duplicate files. Not even any triplicate files. * %defattr properly used, proper file permissions * Proper %clean * consistent use of $RPM_BUILD_ROOT * doc package not necessary * Package functions w/o docs * No devel package to fuss over * Includes proper desktop file - uses desktop-file-install * Scriptlets are sane -=- I no longer have a modem for it to configure, so I have not tested this package. But that is a *should* and not a *must* -=- Output of rpmlint on mock built fc5 i386 packages: [mpeters@jerusalem result]$ ls *.rpm gnome-ppp-0.3.23-1.fc5.i386.rpm gnome-ppp-debuginfo-0.3.23-1.fc5.i386.rpm gnome-ppp-0.3.23-1.fc5.src.rpm [mpeters@jerusalem result]$ rpmlint *.rpm [mpeters@jerusalem result]$ echo $? 0 [mpeters@jerusalem result]$ APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review