Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netpanzer-data - Data files for netpanzer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190397 andreas@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |190396 nThis| | ------- Additional Comments From andreas@xxxxxxxxx 2006-05-01 21:46 EST ------- Good: * proper naming * spec file name matches %{name} * package meets packaging guidelines * License is GPL, License meets packaged COPYING * Spec file written in American English * Spec file is understandable * Package succesfully builds in mock on devel x86_64 and FC-5 x86 * No locales/shared libraries to worry about * No static/libtool files * Package not relocatable * Package owns all directories it creates * No duplicate files * Proper file permissions, proper %defattr(...) in spec file * Package contains necessary game-data for netpanzer, conforming to the Packaging Guidelines * No need for separate doc package * %doc files not needed for runtime * No header/other devel package files to worry about * Desktop File not needed * Package is correctly set to noarch. Approved, pending sponsorship and successfull review of #190396 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review