Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scipy-0.4.8 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188482 ------- Additional Comments From ed@xxxxxxx 2006-05-01 11:16 EST ------- Hi Neal, this isn't a full review, just a few quick observations: - Is this your first package? If so, we'll add FE-NEEDSPONSOR per: http://fedoraproject.org/wiki/Extras/Contributors - incorrect BuildRoot: http://fedoraproject.org/wiki/Packaging/Guidelines - please either make Source0 a full URL or indicate (with some comments in the spec file) how one can generate the tar-ball from, for instance, the upstream CVS [this is so we can more easily verify that source matches upstream] - please remove Prefix and Vendor - please add a changelog - please consider changing %defattr(-,root,root) to %defattr(-,root,root,-) You might want to take a look at the review guidelines: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines and build your rpm in mock ("yum install mock") and run your generated RPM through rpmlint ("yum install rpmlint") to see if you might find any other items -- it could make the job easier easier for reviewers! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review