Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_extract_forwarded https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177556 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-04-28 22:45 EST ------- Well, heck, I worked up this review and then I noticed the NEEDSPONSOR blocker. But I looked through owners.list and I see that rpm@xxxxxxxxxx already owns three packages, so perhaps that tag is out of date. I'll go ahead and include the review and just leave this as FE-NEW until things are cleared up. * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: d7aeb59fa81cbe74c485c33873ea1c65 extract_forwarded-2.0.2.tar.gz d7aeb59fa81cbe74c485c33873ea1c65 extract_forwarded-2.0.2.tar.gz-srpm * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane. * no shared libraries are present, but they're not in the default locations so there's no need to call ldconfig. * package is not relocatable. * creates no directories. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present; no upstream test suite. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED, assuming the NEEDSPONSOR blocker is incorrect. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review