Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ccrtp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180300 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-04-28 16:08 EST ------- Issues: src/ccrtp/rtp.h is executable in the source tarball. It gets stuck in the debuginfo package, which causes rpmlint to complain: E: ccrtp-debuginfo script-without-shellbang /usr/src/debug/ccrtp-1.3.7/src/ccrtp/rtp.h I suggest just doing chmod 644 src/ccrtp/rtp.h in %prep. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * license field matches the actual license. * license is open source-compatible and is included in the package as %doc. * source files match upstream: 6621be1852bd90c3dbbafa895618d8f0 ccrtp-1.3.7.tar.gz 6621be1852bd90c3dbbafa895618d8f0 ccrtp-1.3.7.tar.gz-srpm * BuildRequires are proper. * package builds in mock (development, x86_64). X rpmlint complains (see above) * final provides and requires are sane. * shared libraries are present; ldconfig is invoked as necessary. * package is not relocatable. * owns the directoryies it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. X rtp.h has inappropriate permissions. * %clean is present. O %check not present; no test suite upstream. * code, not content. O documentation is large, but is all development-related and in the -devel subpackage. * %docs are not necessary for the proper functioning of the package. * headers are in -devel subpackage. * pkgconfig files are in -devel. * unversioned libraries are in the -devel subpackage. * no libtool .la droppings. * not a GUI app. With just one minor issue, I'll go ahead and approve and you can fix it when you check in. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review