Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 ------- Additional Comments From wart@xxxxxxxxxx 2006-04-28 11:15 EST ------- (In reply to comment #36) > MUST Fix: > --------- > * Add missing "Requires(Pre): /usr/sbin/groupadd" Added. > * Package must own /usr/share/bsd-games Good catch. It's owned now. > Should Fix: > ----------- > * "# It looks like textutils became coreutils at some point. I'm not sure > # what is needed from it, so I'm commenting it out until I can find out. > #Requires: textutils" I never did figure out what needs it. I didn't notice any obvious exec() or system() calls to external applications. > * Maybe use "BSD" as license, as all games eem to be under one or the other > variant of the BSD license? I won't object to that. I used Distributable as that's what RH7 used for the license before it was dropped. > * Shouldn't the highscore files be marked %config(noreplace) ? I say no. If the high score file formats changes at any time then we want to make sure that the old ones get removed. We could mark them as %config only, but that seems pointless because the only reason to preserve the old scoreboard files is if a migration tool is also provided to move it to the new format, and I don't see that happening for any of these games. > * Suspicious compiler warnings: > "canfield/cfscores/cfscores.c:130: warning: comparison of unsigned expression < > 0 is always false" > "hunt/hunt/playit.c:117: warning: comparison is always true due to limited > range of data type" > "hunt/hunt/playit.c:652: warning: comparison is always true due to limited > range of data type These are part of some paranoid error checking. All are harmless. > "phantasia/setup.c:71: warning: 'path' may be used uninitialized in this function" This is a bogus warning. Besides, this file is only used during the %build phase to create the initial shared game files, not as part of any shipped executable. New package with MUSTFIX fixes: http://www.kobold.org/~wart/fedora/bsd-games-2.17-8.src.rpm http://www.kobold.org/~wart/fedora/bsd-games.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review