Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-04-27 14:08 EST ------- I'm slowly descending into the bsd-games source, some initial remarks: 1) in bsd-games-2.17-hackgid.patch (line 81) you've seem to have left in / added a debug printf. 2) in hack you allow the user to specify the save game location and then the savegame gets opened with full gamehack gid rights. This is a problem. Please modify hack so that the first thing it does in main is: gamehack_gid = getegid(); setgid(getgid()); Where gamehack_gid is a global available gid_t and then when it needs the extra rights it should do: setgid(gamehack_gid); // do stuff setgid(getgid()); 3) The same (2) probably also goes for the other games which don't permanently drop their setgid rights with setresgid. The spec looks good, but it will probably take me some time to properly review all the setresgid using games for any problems. In the mean time a new version addressing the above would be nice. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review