[Bug 186452] Review Request: kdebluetooth: The KDE Bluetooth Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdebluetooth: The KDE Bluetooth Framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186452


bugzilla@xxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|fedora-extras-              |fedora-package-
                   |list@xxxxxxxxxx             |review@xxxxxxxxxx

ville.skytta@xxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |ville.skytta@xxxxxx
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From ville.skytta@xxxxxx  2006-04-26 14:10 EST -------
Notable rpmlint messages:
  E: kdebluetooth zero-length /usr/share/icons/locolor/16x16/apps/khciconfig.png
  E: kdebluetooth zero-length /usr/share/icons/locolor/32x32/apps/khciconfig.png

The default hcid start/stop commands in the pairing dialog's file locations
could be fixed by eg. this (although I'm not certain whether they're too useful
in the first place):
  sed -i -e 's|/etc/init\.d/bluez-utils|/etc/init.d/bluetooth|' \
    kdebluetooth/kbluetoothd/kcm_btpaired/pairedtab.cpp
The default for the link key file isn't too useful either, but I don't know what
would be better as the location in FC varies depending on the device id as in
/var/lib/bluetooth/<deviceid>/linkkeys

gnome-bluetooth uses just "Application;System;" as the desktop entry categories
for the menu icons, whereas the "Network" category in kdebluetooth's ones place
the icons in "Internet".  Consider doing a s/Network/System/ in kdebluetooth?

The all-lowercase menu entry names look a bit silly and inconsistent with
everything else IMHO, how about something like these instead:
- kbluetoothd: Bluetooth Meta Server (or KBluetoothD)
- kbtobexclient: Bluetooth OBEX Object Push client (or KbtOBEXClient)
- kbtserialchat: Bluetooth Serial Chat (or KbtSerialChat)

libirmcsynckonnector.so should probably be in the main package, no?

Missing dependencies in -devel, from #includes in installed headers: qt-devel,
bluez-libs-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]