Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 wart@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |wart@xxxxxxxxxx ------- Additional Comments From wart@xxxxxxxxxx 2006-04-25 19:58 EST ------- The setgid handling could be improved to be a little safer. The current setgid patch uses "setegid()" to temporarily drop setgid rights until it tries to write to the score file. It would be better if the scorefile were opened once at the beginning of the program, then dropped permanently with setresgid(). Additionally, the "LoadScores()" function shouldn't need any setgid/getgid code at all if you make the high score file mode 0664 (it's currently 0060). I don't see any reason why it couldn't be world readable. I'll do a full review, but it would be easier if the above items were fixed in CVS first. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.