[Bug 189713] Review Request: gnubg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnubg


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189713





------- Additional Comments From bdpepple@xxxxxxxxxxxxx  2006-04-23 16:06 EST -------
Note: This is not a formal review.

1. The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
2. Normally, the Source should be a full url, but I'm assuming your using CVS. 
It should probably marked as such.
3. Your missing quite a few BuildRequires.  You should use Mock to verify that
your package will build correctly.  http://fedoraproject.org/wiki/Extras/MockTricks
4. Sub-packages Requires is incorrect.  It should be %{name} = %{version}-%{release}
5. The sub-packages needs %defattr(-,root,root,-)
6. Scriptlet for TexInfo is incorrect.
http://fedoraproject.org/wiki/ScriptletSnippets#head-117e9450bc166ceb4251bf8d87a9dd4e862442a4

That's probably more than enough stuff for you to work on for now.  I would
suggest fully reading the wiki, since almost all of these issues are addressed
there. http://fedoraproject.org/wiki/Extras


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]