[Bug 187235] Review Request: ices - icecast streaming source client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ices - icecast streaming source client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187235


bugzilla@xxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|fedora-extras-              |fedora-package-
                   |list@xxxxxxxxxx             |review@xxxxxxxxxx

Matt_Domsch@xxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |NOTABUG
         AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |Matt_Domsch@xxxxxxxx




------- Additional Comments From Matt_Domsch@xxxxxxxx  2006-04-23 14:38 EST -------
looks quite good (nice cleanup from my attempt last fall!).  A few nits which
can be fixed at CVS checkin time:

Please chkconfig --add only on initial install, not upgrade.
%post
if [ $1 = 1 ]; then
    /sbin/chkconfig --add ices
fi

config(noreplace) the logrotate file:
%config(noreplace) %{_sysconfdir}/logrotate.d/ices



APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]