Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kismet -- A WLAN detector, sniffer and IDS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165314 ------- Additional Comments From enrico.scholz@xxxxxxxxxxxxxxxxxxxxxxxxx 2006-04-23 07:23 EST ------- * Sat Apr 22 2006 Enrico Scholz <enrico.scholz@xxxxxxxxxxxxxxxxxxxxxxxxx> - 0.0.2006.04.R1-1 - updated to 2006-04-R1 - fixed/improved some ./configure checks - removed the starting 'A' from the summary - added a bunch of patches fixing compiler warnings http://ensc.de/fedora/kismet/kismet.spec http://ensc.de/fedora/kismet/ =========== > *Summary must not start with "A ...." drop the "A " . I could not find such a rule in the packaging guidelines and from my linguistic feeling, a leading "A " sounds better. But ok; I am not a native english speaker so I believe you and removed the "A ". > *These: > Requires(pre): %crontabdir > Requires(postun): %crontabdir ... are required resp. the best current way to express: * the directory must exist before the package places files into it. Else, when the directory is a symlink (e.g. compare /etc/init.d) in the owning package, you will create oddities. * the package must be removed before the directory. Else, the directory can not be removed because it still contains files from 'kismet' and becomes orphaned. Therefore, a strict '%crontabdir -> kismet' order on installation, and 'kismet -> %crontabdir' order on uninstallation is required. A plain 'Requires:' does not *guarantees* such an order. > W: kismet-debuginfo dangling-relative-symlink /usr/src/debug/kismet-2005-08-R1/libpcap-0.9.1-kis/bpf_filter.c ./bpf/net/bpf_filter.c > Most of these are OK / have a good reason, so they are ok, it would > be nice if you could fix the last one though, but that is not a > blocker. I think this is a bug in rpm's debuginfo-generator and do not know how to solve it cleanly. > *Redundant BR: ImageMagick-devel already requires libtiff-devel and > libjpeg-devel, please remove those from the BR-s required for the FC4 ImageMagick-devel and they do not hurt on FC5; I added a comment to explain it. > *This comment: > # set our 'kismet' user, disable GPS and log into ~kismet/logs by > Is no longer correct as logs now go to /var/log/kismet thx, fixed it > *These compiler warnings look really suspicious: don't occur anymore in recent version, but... > * Upstream has a much newer version, it would be nice to upgrade to > that version. ok, updated to it. But... it causes ugly warnings and I created a lot of patches fixing them. They are reported upstream; see http://www.kismetwireless.net/Forum/General/Messages/1145789909.7993579 I know that they are making the new package different to this one reviewed by you, but I think they are required (at least the -packed and -alias patches). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.