Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hugs98 - Haskell Interpreter https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167974 ------- Additional Comments From petersen@xxxxxxxxxx 2006-04-20 00:18 EST ------- (In reply to comment #5) > Here is the new srpm: > http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/hugs98-2005.03-1.fc5.src.rpm Thanks. I think buildrequires libXt-devel covers libICE-devel and libSM-devel, and also freeglut-devel pulls in mesa-libGL-devel and mesa-libGLU-devel, and libX11-devel requires xorg-x11-proto-devel anyway. libX11-devel seems sufficient for HsXlib and AFAICT libXt is only checked for in configure but not actually included by any of the library sources. Also better to keep openal-devel around for when HOpenal gets updated (ghc-6.4.2 includes a newer version apparently). And it builds on fc4 anyway. > * I moved the demos into /usr/share/doc. I also remove the > Makefile which doesn't make sense in this context. Good. > * I split off the packages x11, opengl, glut and hgl. I hope > I got the dependencies right. I used lowercase names, because > I find it aesthetically more pleasing :-) Great. :) > * I make the demos package depend on hugs98-glut and hugs98-hgl, > since there are demos that use them. I wouldn't want to > further split the demos package. Ok. Btw what is "touch src/stamp-h.in" needed for? Also seems to me "make install" is good enough, do the docs really need to be installed separately? Otherwise it looks very good to me, thanks. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.