Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 wart@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wart@xxxxxxxxxx ------- Additional Comments From wart@xxxxxxxxxx 2006-04-19 12:54 EST ------- A few things stand out in the spec file: * Source0: should be the full url to the source archive * BuildRoot is not the recommended value for FE * It might be useful to add %{?dist} on the release tag * Summary should not end in '.' or begin with 'A' The Games SIG also recommends the following: * Static game data should be in %{_datadir}, not /usr/games/%{name} * high score file should be put directly into /var/games, or in /var/games/Maelstrom if there are multiple variable data files for the game. I didn't look at the setgid parts of the source code yet, but that will also need to be reviewed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.