Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: raptor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189309 ------- Additional Comments From bugs.michael@xxxxxxx 2006-04-19 07:36 EST ------- Created an attachment (id=127980) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=127980&action=view) some spec fixes Attached patch includes some fixes. | checking GRDDL parser requirements... no - libxml2 and libxslt | are both not available It's missing "BuildRequires: libxslt-devel". * BR curl libxml2 are redundant, because of BR curl-devel libxml2-devel * ASL2? While the old Apache Software License 1.1 maybe was called ASL by some people, better give the new "Apache Licence, Version 2.0" its full name, so "Licence: LGPL or Apache License Version 2.0" ( http://www.opensource.org/licenses/apache2.0.php ) * No reason not to use the %configure macro. * The following two are a major problem IMO: $ raptor-config --libs -L/usr/lib -lraptor -L/usr/kerberos/lib -lcurl -ldl -lgssapi_krb5 -lkrb5 -lk5crypto -lkrb5support -lcom_err -lresolv -lidn -lssl -lcrypto -lz -L/usr/lib -lxml2 -lz -lm -L/usr/lib -lxslt -lxml2 -lz -lm $ pkg-config --libs raptor -L/usr/kerberos/lib -lraptor -lcurl -ldl -lgssapi_krb5 -lkrb5 -lk5crypto -lkrb5support -lcom_err -lresolv -lidn -lssl -lcrypto -lxslt -lxml2 -lz -lm The results of both commands imply that you need much more than just "Requires: libxml2-devel" inside the raptor-devel package. Else linking against libraptor would fail, and developers/packagers would need to add the missing -devel package dependencies manually. Painful. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.