[Bug 188105] Review Request: torque

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: torque


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188105


bugzilla@xxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|fedora-extras-              |fedora-package-
                   |list@xxxxxxxxxx             |review@xxxxxxxxxx

ed@xxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|fedora-package-             |fedora-extras-
                   |review@xxxxxxxxxx           |list@xxxxxxxxxx
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From ed@xxxxxxx  2006-04-17 21:28 EST -------
The SRPM [please note the "6" instead of "5" in release tag since the 
SRPM URL in comment #14 has a typo] at:

  http://www-rcf.usc.edu/~garrick/torque-2.1.0p0-0.6.200604171430cvs.src.rpm
  sha1sum: ba0a569763d6b91697c9a40723b392be464ab64e

does cleanup everything mentioned in comments #12--13 and heres the
remainder of the review:

very minor nit:
 + please consider adding the "-q" option to %setup so that the 
   build logs are a little shorter and more readable (just a 
   request--by no means a blocker!)

good:
 OK - source matches upstream
 OK - macro usage looks consistent although there are some 
      harmless quirks like having both %__rm and %{__rm}
 OK - proper use of -devel
 OK - desktop files appear to have correct install syntax
 OK - scriptlets look sane to me
 OK - installed and runs with out seg-faulting on a single FC4 i386
      machine (I do need to go dig up the syntax for creating default 
      queues, etc. because a quick "qsub -I" seems to wait forever and 
      I imagine its an incomplete setup and thus my fault.  Other 
      commands such as "pbsnodes -a" and "qmgr" work just fine--no 
      segfaults.)

I don't see any blockers so its APPROVED.

Congrats on the first package and please feel free to contact me if you 
want any help with FE CVS, the build system, etc.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]