On 12 October 2012 at 8:31, Brendan Jones <brendan.jones.it@xxxxxxxxx> wrote: > I've packaged this for the spin if anyone would like to review it. > > Very simple package containing a few perl scripts. > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=865303 > [2] http://code.google.com/p/realtimeconfigquickscan/ Hi Brendan, Looks pretty good. I do have a few suggestions though. - Prepend a URL to each source name to aid people in finding the sources? For instance: Source0: http://fee.fie.fum/downloads/%{name}-1234.tgz - QuickScan is the GUI, right? If so, maybe add a menu item for it? Something like this? It would go in the %install step. # install FreeDesktop (Mandriva 2010, Fedora 16) menu entry mkdir -p $RPM_BUILD_ROOT%{_datadir}/applications/ cat << EOF > %buildroot%{_datadir}/applications/%{name}.desktop [Desktop Entry] Type=Application Exec=%{_bindir}/%{name} Icon=%{name} Name=%{name} Comment=Something goes here Categories=Office;Network;Email; <-- this would change EOF - If you add the menu item, then you also need to update the desktop, like so: %post update-desktop-database &> /dev/null || : %postun update-desktop-database &> /dev/null || : - Why are you removing the "shebangs"? Don't the .pl scripts need them in order to run without doing 'perl script.pl'? Especially, the GUI would need #!/usr/bin/perl in order to run from the menu. I hope my observations are useful. Thanks for packaging this! -- Kevin _______________________________________________ music mailing list music@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/music
