Re: Games SIG Self-Introduction: Interested in Emulators

[Andrea Musuruane <musuruan@xxxxxxxxx>]

Hi!

On Thu, Jan 12, 2017 at 3:33 PM, Daniel Moerner <dmoerner@xxxxxxxxx> wrote:

I've already started working on packaging an emulator for Fedora; I
chose to start with higan[2], an actively developed, very high accuracy
emulator for retro Nintendo systems which is licensed under the GPLv3
and has been included in Debian since 2011. I have built the package and
tested it to the best of my ability with fedora-review; it is available
on copr.[3] I plan to submit a review ticket very soon, I am hoping to
hear back from upstream about the (minor) patches I applied to the
source. When I submit the review ticket, I'll CC this list with my
general self-introduction. I welcome any help now and later!

Higan was submitted for review to RPM Fusion a long time ago:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2682

At some point I even tried to review it but it seems the original packager lost interest.

Maybe you can have a look anyway.

I do have one question about licensing that came up as I was working on
this package. The SIGs/Games/Packaging Guidelines[4] say the following:
"License file must be included to clarify legal status, even if upstream
doesn't provide it in the source tarball."

Higan doesn't include a separate license file; rather, the license for
each component is stated in a one-line comment in the primary header
file for that component. (I know this is not ideal.) Following this
guideline, I made a license file of my own detailing the license for
each component and the header file in which it can be found stated by
the author.[5] I also included the full text of GPLv3. But then I
noticed the following two "should" comments in fedora-review:

"[ ]: Package does not include license text files separate from upstream
[ ]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of
     the license(s) for the package is included in %license."

It looks like by following the SIG Packaging Guidelines and adding a
license file, I am violating these "should" recommendations. Obviously
they are only "shoulds", but I wanted to confirm that I am understanding
the license requirements of the Games SIG correctly.

This is something I already noted during my quick review in RPM Fusion. You should contact upstream and encourage them to include the text of the license.

More info here:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

Bye,

Andrea

 

_______________________________________________
Fedora Games SIG mailing list -- games@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to games-leave@xxxxxxxxxxxxxxxxxxxxxxx