Re: pychess update (typo review)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Qui, 2016-03-03 at 11:52 +0100, Hans de Goede wrote:
> 
> Hi,
> 
> On 03-03-16 11:28, Hans de Goede wrote:
> > 
> > 
> > Hi,
> > 
> > On 03-03-16 06:54, Sérgio Basto wrote:
> > > 
> > > 
> > > Hi ,
> > > I built pychess in copr [1]
> > > 
> > > dnf copr enable sergiomb/buildsforF21
> > > dnf install or update pychess
> > > 
> > > also attach the patch to update pychess in bugzilla.
> > Thanks, I'll apply patch and build officially updated pkgs
> > for f24+.
> I've just updated pychess for f24+ to 0.12.3, note your patch was
> wrong in a couple of places, e.g. the /usr/share/menu stuff is Debian
> specific and should be removed. Also you should have run rpmlint, as
> that showed a ton of warnings. I've fixed these things up.

Thanks! 
/usr/share/menu stuff , I didn't know what to do.

-sed -i '1d' Players/PyChess.py
+sed -i '1d' System/command.py System/which.py

I don't like this sed, even I don't know what it does but broke
Players/PyChess.py at first place .

> 
> Unfortunatelty 0.12.3 still seems to suffer from bug 1272653.
I have to analyze better the bug (1272653) but in kde looks to me, I
have all normal . I also have kde4 (https://copr.fedorainfracloud.org/c
oprs/sergiomb/kde4for23/ ) 

I think we should also update F23 , because should be updated in F23
before F23 GA, it is a leaf package , and end users will get a better
experience .

> 
> Regards,
> 
> Hans
Best regards,
-- 
Sérgio M. B.

_______________________________________________
games mailing list
games@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/games@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Music]     [Fedora Extras]     [Kernel]     [Fedora Desktop]     [Fedora Directory]     [PAM]     [CentOS]     [Gimp]     [Yosemite News]     [Yosemite Camping]

  Powered by Linux