Il 13/03/2013 16:14, Hans de Goede ha scritto:
Hi,
On 03/13/2013 01:13 PM, Alberto Chiusole wrote:
Hi all,
I'm Alberto, alias bebo_sudo on the net, and I'm an Italian fedora user.
I'm trying to get my rpm of GtkRadiant onto the official repo but I'm
having some troubles.
Official website: http://icculus.org/gtkradiant/
Here my review request on bz:
https://bugzilla.redhat.com/show_bug.cgi?id=836840
I uploaded srpm and spec as they are now.
SRPM:
http://sourceforge.net/projects/bebosudo-rpms/files/gtkradiant/F18/SRPM/gtkradiant-1.6-20121007.5.fc18.src.rpm/download
spec:
http://sourceforge.net/projects/bebosudo-rpms/files/gtkradiant/F18/SRPM/gtkradiant.spec/download
The last comment I made was on december, but I edited my package and
bumped into a huge bug that keeps me from having a working package.
I wrote to the ML of gtkradiant, talking about this error
(http://icculus.org/pipermail/gtkradiant/2013-February/011841.html)
but nobody managed to solve.
I'm not a C coder but I think the error is here:
https://github.com/TTimo/GtkRadiant/blob/master/radiant/preferences.cpp#L3414
Is there anyone who can help me to fix it?
Thank you for the time you spent reading.
I've taken a quick look at your gtkradiant packages, but as already
indicated by
both Jason and Michael in:
https://bugzilla.redhat.com/show_bug.cgi?id=836840
Your package as is, is no good. I'm sorry to say so, but it is no good
at all.
You cannot create package for a FOSS distro such as Fedora by using
precompiled
binaries from upstream and putting those in an rpm.
If you look at other spec files in Fedora you will see they all start
with the
C source code, then compile and install this, ie:
%build
%configure
make
%install
make install DESTDIR=$RPM_BUILD_ROOT
Rather then using prebuild binaries, using prebuild binaries simple is
not
acceptable within Fedora.
So what you need to do is get the sources and use those as Source0,
since the sources are on github, and they're not tagging releases
just take a git-snapshot .zip file as Source0 by clicking on the zip
button here:
https://github.com/TTimo/GtkRadiant
This means that your Source0 won't have a url and rpmlint will
complain, but
that is ok. Simple add a comment above the Source0 tag to explain where
the sources come from.
But I see that gtkradiant also uses scons as a buildsystem, which is a
pain
to work with. Since you're new to packaging it would likely be better to
choose a different package as your first Fedora packages.
Sorry I could not be more helpful.
Regards,
Hans
_______________________________________________
games mailing list
games@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/games
Ok. Thanks Hans for the quick reply.
I'll reply on bugzilla one of these days.
bebo
_______________________________________________
games mailing list
games@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/games
