Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tremulous-data - Data files for tremulous the FPS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204125 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-09-05 15:09 EST ------- (In reply to comment #6) > - Spec file seems fine, three minor nitpicks : > - The Source1 "tremulous-copyright.txt" gets installed as > "fedora-copyright.txt", why two different names? The name starting with tremulous is to make clear to which package it belongs when the src rpm gets installed and the files dropped under /usr/src/redhat/SOURCES Since under /usr/share/doc it already is in a tremulous dir the trmulous in the name isn't needed and since the file is added to meet the fedora copyright guidelines I call it fedora-copyright.txt . > - Maybe you should uncomment the %build line, even though the section is > empty, since IIRC not having %build has already caused weird things to > happen. I actually commented it because in another review of a similar data only package the reviewer wanted it commented, so I'm leaving it as is as this seems to work fine for the other package. > - It's "basically", not "basicly". Fixed I'm importing it now (slow slow lookaside cache upload, at times like the the A in ADSL sucks). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-games-list mailing list Fedora-games-list@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-games-list
