Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sturmbahnfahrer - Simulated obstacle course for automobiles https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199310 hugo@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |hugo@xxxxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From hugo@xxxxxxxxxxxx 2006-07-21 17:14 EST ------- (Sorry about the last comment, access keys sometimes are annoying) Now onto a formal re-review :-) Thanks to the other guys for submitting comments and reviewing it too! MUST OK: * rpmlint gives no warnings * Packaging is named according to Package Naming Guidelines * Spec filename ok and package follows Packaging Guidelines * Package is licensed under GPL, license file included * Specfile in English and legible * Tarball in packages matches with upstream's checksum: 25d8907b234c9ebaa91c590c6fcbf9ba sturmbahnfahrer-1.1.tar.gz * Package builds fine * BuildRequires are fine * Package does not contain locale files * Package does not contain shared libraries * Package does not own other packages' directories * All files in %files are listed fine and not duplicated * Permissions on the specfile are fine * Clean section is used in the right way * Macros are used consistently * No need for a -doc sub-package * No need for development package * Package does not contain libtool archives * Package installs desktop file and icon SHOULD OK: * Package builds fine in mock * Package runs fine I see no blockers at all, package approved! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ @xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-games-list
