On Thursday 01 March 2007, Balint Cristian wrote: > Author: cbalint > > Update of /cvs/extras/rpms/ogdi/devel > In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv23723 > > Modified Files: > ogdi.spec > Log Message: > disable fedora compile flags to avoid internal ogdi bugs. (tofixupstream) [...] > -export CFLAGS="$RPM_OPT_FLAGS -fPIC -DPIC -DDONT_TD_VOID -DUSE_TERMIO" > +# do not compile with ssp. it will trigger internal bugs (mustfixupstream) > +export CFLAGS="-g3 -fPIC -DPIC -DDONT_TD_VOID -DUSE_TERMIO" > %configure \ The comment mentions ssp, but -O2 -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector and -mtune=... have disappeared as a result of this change as well. If that's intentional, I think it should be accompanied with a comment explaining why they went away too. The idea is that known problematic flags are filtered out of $RPM_OPT_FLAGS, not all of them thrown away. http://fedoraproject.org/wiki/Packaging/Guidelines#CompilerFlags -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
