Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hylafax https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188542 fedora.wickert@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora.wickert@xxxxxxxx ------- Additional Comments From fedora.wickert@xxxxxxxx 2006-04-11 09:02 EST ------- There are too many issuse with your specfile to list them one by one. Just to name a few: - don't use "%define" for name and version - don't use "%define fc_rel", use "disttag" instead, see http://fedoraproject.org/wiki/DistTag - don't use epoch if not necessary - don't use "%define initdir /etc/rc.d/init.d". If you really need it, it should be "%{_initrddir}". - Source0 needs an absolute URL (http://...) - License field not valid, see http://fedoraproject.org/wiki/Packaging/Guidelines#head-76294f12c6b481792eb001ba9763d95e2792e825 - remove "Packager:", see http://fedoraproject.org/wiki/Packaging/Guidelines#head-c17fb8c1ce9be40da720a2b25d1e2a241062038f - BuildRoot should be "%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)", see http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1 - are you sure about the BuildRequires/BuildPrereq? - "Requires: rpm >= 3.0.5" ist stupid and can be dropped - try to use "%configure" instead of "./configure" and use $RPM_OPT_FLAGS correctly and not with make, see http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf - no need to pass default options to configure (like PAGESIZE) - change "--with-AWK=/usr/bin/gawk \" to "--with-AWK=%{_bindir}/gawk \" - same for vgetty and mgetty which will become %{_sbindir}/[v|m]getty - doesn't use parallel make, see http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e - use "%defattr(-,root,root,-)" instead of "(-,root,root)" - remove generic INSTALL from doc section. Not needed when installed from RPM. - macro usage inconsistent: {initdir} vs. {_initdir} which should be %{_initrddir} anyway, see http://fedoraproject.org/wiki/Extras/RPMMacros - empty %pre section - /sbin/ldconfig in %post and %postun is superflurious since the package doesn't put shared libs into the linkers path. - "chkconfig --del" belongs into %preun, see http://fedoraproject.org/wiki/Packaging/Guidelines#head-220f87f993c84311859884f2a033a8706a2c7d7c - Requires(post)/(preun) missing for the scriptlets, see http://fedoraproject.org/wiki/ScriptletSnippets?highlight=%28scriptlets%29#head-24ef9d59bda6032df14cf3cb433ce4ef09348f69 - no changelog at all, see http://fedoraproject.org/wiki/Packaging/Guidelines#head-b7d622f4bb245300199c6a33128acce5fb453213 I'm not sure if we need to create a system user with a fixed uid/gid and use fedora-usermgmt. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
