Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-mailwatch-plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187569 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-04-09 21:07 EST ------- A review: OK - Rpmlint output. OK - Package name. OK - Spec file name matches. OK - Package guidelines. OK - Licsense. (GPL) OK - License field matches in spec. OK - License included in files OK - Spec in american english OK - Spec legible OK - Md5sum of source from upstream e31d32b08f82e24e730831641cdd65f0 xfce4-mailwatch-plugin-1.0.0.tar.bz2 e31d32b08f82e24e730831641cdd65f0 xfce4-mailwatch-plugin-1.0.0.tar.bz2.1 OK - Compiles and builds on one arch at least. See below - All required buildrequires included? OK - Locale handling/find_lang. OK - Owns all directories it creates. OK - No duplicate files in %files listing. OK - Permissions on files correct. OK - Clean section correct. OK - Macros consistant. OK - Code not content. OK - No .la files. See Below - Doesn't own any files/dirs that are already owned by others. Items needing attention: 1. The summary has "Summary: Quicklauncher plugin for the Xfce panel" Shouldn't that be "Mail Watcher plugin for the Xfce panel"? 2. Some of the dirs that this package owns are owned by lots of other packages. In particular: /usr/share/icons/hicolor /usr/share/icons/hicolor/48x48 /usr/share/icons/hicolor/48x48/apps /usr/share/icons/hicolor/scalable /usr/share/icons/hicolor/scalable/apps /usr/share/xfce4/doc/C /usr/share/xfce4/doc/C/images This package shouldn't also need to own those I wouldn't think. Perhaps require hicolor-icon-theme and xfce4-panel to make sure those dir dependencies are met. 3. Doesn't build in mock. Looks like it might be missing: BuildRequires: imake libXt-devel -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
