[Bug 188105] Review Request: torque

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: torque


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188105





------- Additional Comments From ed@xxxxxxx  2006-04-08 16:54 EST -------
Hi Garrick, using your latest spec and the patch above I put together:

http://mitgcm.org/eh3/fedora_misc/torque-2.1.0p0-0.4.200604071240.src.rpm
md5sum:
2470a40280b9b65d6b49c9fffe5f46bb  torque-2.1.0p0-0.4.200604071240.src.rpm

which builds locally (and probably in mock since it worked with a 
very similar previous version).  In any case, heres the rpmlint output:

  W: torque invalid-license Freely redistributable (See PBS_License.txt)

[repeated many times] -- probably OK to ignore since the license does appear to 
satisfy the Fedora requirements

  W: torque no-documentation

[repeated many times] -- OK to ignore

  W: torque incoherent-version-in-changelog 2.1.0p0-0.3.200604071240
     2.1.0p0-0.4.200604071240

the naming does not exactly follow the pattern in 
  http://fedoraproject.org/wiki/Packaging/NamingGuidelines 
but it is pretty close -- could you please use the "YYYYMMDDcvs" 
pattern per the guidelines?

  E: torque no-binary
  E: torque non-standard-dir-perm /var/torque/spool 01777
  W: torque non-standard-dir-in-var torque

probably OK to ignore

  W: torque-client unstripped-binary-or-object /usr/sbin/pbs_iff
  E: torque-client setuid-binary /usr/sbin/pbs_iff root 04755
  E: torque-client non-standard-executable-perm /usr/sbin/pbs_iff 04755

These are worrisome.  The unstripped binary can probably be fixed
in the rpm build somehow.  And does the /usr/sbin/pbs_iff really 
need to be suid?

  E: torque-mom non-standard-dir-perm /var/torque/checkpoint 0700
  E: torque-mom non-standard-dir-perm /var/torque/undelivered 01777
  E: torque-mom non-standard-dir-perm /var/torque/mom_priv/jobs 0751
  W: torque-mom non-standard-dir-in-var torque
  W: torque-mom incoherent-init-script-name pbs_mom
  E: torque-scheduler non-standard-dir-perm /var/torque/sched_priv 0750
  W: torque-scheduler non-standard-dir-in-var torque
  W: torque-scheduler incoherent-init-script-name pbs_sched
  E: torque-server non-standard-dir-perm /var/torque/server_priv/acl_groups 0750
  E: torque-server non-standard-dir-perm /var/torque/server_priv/queues 0750
  E: torque-server non-standard-dir-perm /var/torque/server_priv 0750
  E: torque-server non-standard-dir-perm /var/torque/server_priv/acl_hosts 0750
  E: torque-server non-standard-dir-perm /var/torque/server_priv/acl_users 0750
  E: torque-server non-standard-dir-perm /var/torque/server_priv/acl_svr 0750
  E: torque-server non-standard-dir-perm /var/torque/server_priv/jobs 0750
  W: torque-server non-standard-dir-in-var torque
  W: torque-server incoherent-init-script-name pbs_server

The above can probably (?) be ignored.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

-- 
fedora-extras-list mailing list
fedora-extras-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-extras-list

[Index of Archives]     [Fedora General Discussion]     [Fedora Art]     [Fedora Docs]     [Fedora Package Review]     [Fedora Desktop]     [Big List of Linux Books]     [Yosemite Backpacking]     [KDE Users]

  Powered by Linux