Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Crypt-Random https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183374 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-04-07 23:07 EST ------- perl-Math-Pari is stalled in review, but it doesn't look like there are any issues (such as license) that would prevent the package from eventually being accepted so I'll go ahead and review this. A mock build is clean if the current perl-Math-Pari submission (2.010704-1) is built and added to the repository. rpmlint is silent. * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and conforms to the Perl template. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: 5730c9d5acdd698790216d354ffb0513 Crypt-Random-1.25.tar.gz 5730c9d5acdd698790216d354ffb0513 Crypt-Random-1.25.tar.gz-srpm * package builds in mock (with dependencies added) * BuildRequires are proper. * no shared libraries are present. * package is not relocatable. * owns the directory it creates, except for %{_bindir} which is mandated by FHS. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. * The package owns %{perl_vendorlib}/Crypt, which will probably also be owned by any module under the Crypt:: namespace. However, none of the dependencies create this directory so there is no alternative but for this package to own it. APPROVED, subject of course to the approval of perl-Math-Pari. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
