Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: conserver - serial console server daemon/client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188309 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |tcallawa@xxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From tcallawa@xxxxxxxxxx 2006-04-07 16:34 EST ------- - rpmlint checks return: nothing! - package meets naming guidelines - package meets packaging guidelines - license (Distributable, BSD/MIT-ish, same as libtabe) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file One minor note: It would be nice to see LICENSE included as %doc before commit. Otherwise, this is great. Approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list