Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: phpMyAdmin - Web based MySQL browser written in php https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187843 mfleming+rpm@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfleming+rpm@xxxxxxxxxxxxxxx | |m ------- Additional Comments From mfleming+rpm@xxxxxxxxxxxxxxxx 2006-04-04 04:43 EST ------- See also http://www.enlartenment.com/packages/fedora/5/x86_64/repodata/repoview/phpmyadmin-0-2.8.0.2-1.fc5.mf.html for my contribution. Not a review per-se, but some comments after an elementary look at the package: - Feel free to be more verbose in the %description and summary - you can do far more than simply browse databases with it, it's a full admin app after all. - The source package doesn't ship a default config.inc.php file, users would normally create one on the fly. Yours is a good base but I would personally create a %{_localstatedir}/www/phpmyadmin/scripts/config dir per the install instructions (unfortunately they want it world writable *sigh*) allowing the user to create the config via the included /scripts/setup.php interface without much hassle. - I would not restart apache in %post/%postun - either issue a reload or leave it for the administrator to perform manually. Look at the services related scriptlet at http://www.fedoraproject.org/wiki/ScriptletSnippets#head-a1898cc5440737a43df9b41b9ad6d7e7c7c3e6e2 Michael. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
