Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnokii - a mobile telephone manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184291 ville.skytta@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From ville.skytta@xxxxxx 2006-04-01 01:40 EST ------- Looks good, but a couple of little things: Please move the iconv invocations to %prep like other source modifications. In %install they're possibly done multiple times with rpmbuild -bi --short-circuit. xgnokii.pc refers to %{prefix}/share/xgnokii for xgnokii's data files, maybe it would be a good idea to have the xgnokii package create/own that dir. These can be changed after the import and before the first build, approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
