Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: shippy - Space invaders / Galaxians like game with powerups https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186993 ------- Additional Comments From tkmame@xxxxxxxxxxxxxx 2006-03-30 23:57 EST ------- - MUST: rpmlint must be run on every package. The output should be posted in the review. W: shippy no-documentation OKAY: documentation is in shippy-common which is required by shippy E: shippy non-standard-executable-perm /usr/bin/shippy-sdl 02755 OKAY: needed to save high scores W: shippy-allegro no-documentation OKAY: documentation is in shippy-common which is required by shippy-allegro E: shippy-allegro non-standard-executable-perm /usr/bin/shippy-allegro 02755 OKAY: needed to save high scores E: shippy-common score-file-must-not-be-conffile /var/lib/games/shippy.hs ????: I have no idea what this means and rpmlint -I didn't have any idea either. E: shippy-common zero-length /var/lib/games/shippy.hs OKAY: Safe to ignore. package name OKAY spec file name OKAY package meets package guidelines OKAY package OSI license OKAY package matches license in source OKAY license in %doc OKAY spec file in english OKAY spec file legible OKAY sources match upstream sources OKAY package successfully builds on x86_64 for FC5 OKAY package does not contain any extra BRs OKAY all dependencies in BR OKAY [1] no locales in spec OKAY package does not contain shared libraries OKAY package is not relocatable OKAY package owns directories it creates OKAY package contains no duplicate files OKAY file permissions set correctly OKAY package contains good %clean section OKAY macro use is consistant OKAY pacakge contains permissible content OKAY package does not contain large docs OKAY %doc files do not affect runtime OKAY package does not contain any files that should go in -devel OKAY package does not contain any .la files OKAY package contains a %{name}.desktop OKAY package does not own files owned by other packages OKAY One other thing I noticed is when I try to install shippy-common I get: # rpm -ivh shippy-common-1.3.3.7-2.x86_64.rpm error: Failed dependencies: shippy-engine = 1.3.3.7 is needed by shippy-common-1.3.3.7-2.x86_64 however, there is no shippy-engine package, just shippy. APPROVED! [2][3] [1] dumb-devel requires allegro-devel must be fixed! This still fails in mock for FC5. [2] Since this is my first ever official approval perhaps wart or someone might want to take a quick 2nd look [3] Please review that rpmlint error which I couldn't understand, and look into why installing shippy-common asks for shippy-engine when the package name is just "shippy". Whew! P.S. Joystick works great in both versions now! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
