Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsdiff - binary diff/patch utility https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186566 ------- Additional Comments From matthias@xxxxxxxxxxxx 2006-03-30 12:17 EST ------- Good! What I meant where you answered "???" was that above the "Patch:" line of the spec, you could put someething like : # We patch the Makefile, but only to fix the buils since we don't use "make install" Or something like that, because at first it seems like the patch "fixes" something in the "install:" part of the Makefile. Okay, I'm being picky here, but these inlined comments never harm :-) You'll also need to patch out -O3 from the Makefile, or add CFLAGS=... to the make line and not forget to add -lbz2 to it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
