[Bug 187266] Review Request: gprolog - GNU Prolog is a free Prolog compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gprolog - GNU Prolog is a free Prolog compiler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187266





------- Additional Comments From tibbs@xxxxxxxxxxx  2006-03-29 13:34 EST -------
Someone hopped in while I was writing this, but I'll include these comments anyway.

I may not be qualified to review this, but here are some quick comments:

You comment that it will only compile with -O1 but then substitute in -O0.

Consider adding a comment describing why you substitute out @TXT_FILES@ from
Makefile.in.

Is it acceptable to have the executable under /usr/lib/gprolog-blah/bin and put
a symlink into /usr/bin?  The only examples I can find of this in Core are QT
and RPM.

Do you still need to delete the doc files (Changelog, COPYING, etc.) after you
have removed @TXT_FILES@ from Makefile.in?  Changing the "rm -f" to "rm" shows
that the files don't need to be deleted.

rpmlint complains about /bin/sh dependencies in the doc files.  I think that you
could safely delete BINPROLOG, CIAO, SICSTUS, SWI, WAMCC, XSB and YAP from the
ExamplesPl directory; they aren't even intended to be used by gprolog.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

-- 
fedora-extras-list mailing list
fedora-extras-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-extras-list

[Index of Archives]     [Fedora General Discussion]     [Fedora Art]     [Fedora Docs]     [Fedora Package Review]     [Fedora Desktop]     [Big List of Linux Books]     [Yosemite Backpacking]     [KDE Users]

  Powered by Linux