Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pwgen - Automatic password generation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185407 ------- Additional Comments From pertusus@xxxxxxx 2006-03-27 16:01 EST ------- (In reply to comment #5) > This is my vote for approval. The final word belongs to Patrice as he has done > the first review. I interpret that you are sponsoring James in that case... APPROVED There is only a minor issue, I think the changelog is more readable if there is an empty line between release fields, like * Sat Mar 25 2006 James Bowes <jbowes@xxxxxxxxxx> - 2.05-3 - Add dist tag to release. - Don't strip binary, since rpmbuild will do it. * Fri Mar 24 2006 James Bowes <jbowes@xxxxxxxxxx> - 2.05-2 - Use url for Source0 in spec file. - Use glob for man page extension. - Increment release number. And also you can remove the line - Increment release number. as it is redundant with having a new changelog entry. No need to add a changelog entry for those changes, nor if you change the glob for man pages, and you can do that after importing in the cvs. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
