Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kshutdown https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186817 rdieter@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |177841 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2006-03-27 07:36 EST ------- Added FE-NEEDSPONSOR tracking bug. a few things off the top of my head: 1. drop from %post/%postun: /sbin/ldconfig %{_libdir}/kde not required. 2. missing (at least): BuildRequires: kdelibs-devel 3. use the %find_lang macro, instead of manually adding all those %lang()... entries. Add %find_lang %{name} near the end of your %install section, then use %files -f %{name}.lang 4. Use a full URL for the Source: tag. Something like: Source: http://dl.sourceforge.net/sourceforge/kshutdown/kshutdown-%{version}.tar.bz2 (one line) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
