Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-extras - Additional PHP modules from the standard PHP distribution https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170131 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |tcallawa@xxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From tcallawa@xxxxxxxxxx 2006-03-24 15:20 EST ------- Good: - rpmlint checks return: W: php-dbase invalid-license The PHP License W: php-dbase no-documentation W: php-readline invalid-license The PHP License W: php-readline no-documentation W: php-mcrypt invalid-license The PHP License W: php-mcrypt no-documentation W: php-mhash invalid-license The PHP License W: php-mhash no-documentation W: php-tidy invalid-license The PHP License W: php-tidy no-documentation - package meets naming guidelines - package meets packaging guidelines - license (PHP License) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC-5 (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - no need for .desktop file Good work Dmitry, sorry it took so long to get this reviewed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list