Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 ------- Additional Comments From tkmame@xxxxxxxxxxxxxx 2006-03-23 18:41 EST ------- Probably copying the tar.gz to a different location/name would be eaiser for the reviewers. Comments on this second release: - The package should have a release of 0.2.%{alphatag}%{?dist} and there should be changelog entries showing what you have changed since release 0.1 - This does not build correctly under a mock environment. You must add atleast which and mlocate to the buildrequires. In order to build with FC4 you will need to replace mlocate with slocate. Even with mlocate I get the following error in the configure: checking tcl build dir... locate: can not open `/var/lib/mlocate/mlocate.db': No such file or directory -It also requires an X11 devel package. I tried adding libX11-devel to the buildrequires, but configure still does not find X11: checking for X... no "Could not find X11 devel package NOTE: Even the error message in configure is not being displayed correctly, there must be something wrong in the configure.ac file. Unless the proper Buildrequires are set, the X11 will be set to NO when compiling this package. -I still think the package should be divided up into sub packages. amsn-plugins, amsn-skins, amsn-utils? I'm not sure if this is a requirement or not, but a real reviewer might require it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
