Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pwgen - Automatic password generation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185407 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2006-03-23 06:52 EST ------- I cannot approve, as you are seeking a sponsor, but here are my comments. The Source0 is wrong, as it should be un URL, like Source0: http://dl.sourceforge.net/sourceforge/pwgen/pwgen-%{version}.tar.gz rpmlint gives the following warnings, that should be easily sorted out: W: pwgen strange-permission pwgen-2.05.tar.gz 0755 W: pwgen strange-permission pwgen.spec 0755 Those 2 items are blockers. The remaining are comments. Have you verified that the pending patch ahs been merged? (at a quick glance it seems so) http://sourceforge.net/tracker/index.php?func=detail&aid=1108220&group_id=28391&atid=393206 I personnally prefer to use globs for man pages extensions such that rpmbuild picks the man page whatever compression scheme is used (even none). The corresponding entry in files becomes: %{_mandir}/man1/pwgen.1* Otherwise everything seems ok. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
