Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnochm - CHM file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185261 ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-03-21 16:45 EST ------- Builds, but some deps really should be explicit: * BuildRequires: gettext is missing (required by the %find_lang macro) * Missing dependancy on update-mime-database for %post (package shared-mime-info) * Missing dependancy on update-mime-database for %postun (package shared-mime-info) Otherwise: - rpmlint checks return: W: gnochm conffile-without-noreplace-flag /etc/gconf/schemas/gnochm.schemas can ignore - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no unnecessary BR - locales handled by %find_lang - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
