Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 ------- Additional Comments From tkmame@xxxxxxxxxxxxxx 2006-03-21 05:21 EST ------- Here is my first review. *MUSTs* - Package fails rpmlint checks, shorten descriptions, fix symlinks and set the correct executable bits on files, and fix line endings (see package guidelines) use rpmlint to check your packages for errors and warnings - Package name OKAY - spec file name OKAY - license OKAY - written in english OKAY - legible OKAY - url link OKAY - md5sums do not match that of SRPM. You should provide instructions in comments on how to get the exact sources found in the SRPM. 98871a6bd5b19cc267b4221cedaec863 amsn_cvs.tar.gz d9dcd3587b6df37e39f0c4b59073fd31 ../SOURCES/amsn_cvs.tar.gz - sources build on FC5.x86_64 OKAY - no exceptions in BR OKAY - package not owning its directories BAD - package contains duplicate files BAD - permissions are not set properly on every file BAD - package contains clean section OKAY - macro use is consistant OKAY - package contains permissable content OKAY - %doc files do not affect runtime OKAY - no static libraries or .la files OKAY - desktop file looks okay and desktop-file-utils in BR OKAY - package does not own files in other packages OKAY - application runs without crashing OKAY Additional comments: consider breaking this package up into sub-packages, like amsn-plugins and amsn-skins This is my first ever review, sorry if it's a bad one. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
