Re: Is this acceptable as a patch?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2006-03-19 at 23:45 +0000, Paul wrote:
> Hi,
> 
> I'm currently working on getting z88dk to be architecture neutral, but
> have found a problem in the wholesale build process which I have a
> workaround for in the spec file.
> 
> However, I've found that if I alter the build.sh file to include the
> lines
> 
> PATH=`pwd`/bin:$PATH
> export PATH
> 
> the workaround can be avoided.
> 
> If I was to include that in a large patch, would it cause any sort of
> problems to the buildsys. I am always wary of altering environment
> variables, so would like some guidance on this.

I don't see a problem with that, particularly if you know that `pwd` is
always somewhere sane when build.sh is invoked.

Paul.

-- 
fedora-extras-list mailing list
fedora-extras-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-extras-list

[Index of Archives]     [Fedora General Discussion]     [Fedora Art]     [Fedora Docs]     [Fedora Package Review]     [Fedora Desktop]     [Big List of Linux Books]     [Yosemite Backpacking]     [KDE Users]

  Powered by Linux