Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fcron, a task scheduler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185531 ------- Additional Comments From aportal@xxxxxxxxxxxxxx 2006-03-17 09:08 EST ------- (In reply to comment #1) > First remark on the %pre script: I don't think the code that checks for an older > version and fixup things should be in the fedora spec. It adds a lot of unneeded > complexity without being able to catch all the possibilities. Moreover it uses > /tmp in an insecure way opening the possibility of a symlink attack. > > I think it would be better to have a quick explanation of what should be done in > case there is an old fcron, at the end of the description. Shame on me! This code is to check for very old version which implies fcrontabs conversion. > A nitpick: I think that it is better not to add the package name in the summary, > it will always be added by the utilities that use the summary. OK. > An advice: maybe it isn't sendmail which is required, but smtpdaemon. I'm waiting for an answer from upstream maintainer to know if fcron can support postfix or exim, or if it needs sendmail. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
