Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-PEAR-Command-Packaging: make-rpm-spec command for PEAR https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185423 ------- Additional Comments From jorton@xxxxxxxxxx 2006-03-15 04:05 EST ------- A few nits: "install -c -m ..." is better than "cp -p" empty %doc line %{peardir}/data/PEAR_Command_Packaging looks like it would be unowned is: " -d doc_dir=/docs" really correct? an empty %build can be ommitted IIRC otherwise looks fine to me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
