Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: paco https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184008 ------- Additional Comments From bugs.michael@xxxxxxx 2006-03-11 17:54 EST ------- NEEDSWORK * Take a look at rpm -qlpv paco-1.10.3-1.i386.rpm and notice that it includes several filesystem directories, which it must not include, e.g. drwxr-xr-x /usr/lib/pkgconfig drwxr-xr-x /usr/share/applications drwxr-xr-x /usr/share/locale drwxr-xr-x /usr/share/locale/ca drwxr-xr-x /usr/share/locale/ca/LC_MESSAGES drwxr-xr-x /usr/share/locale/fr drwxr-xr-x /usr/share/locale/fr/LC_MESSAGES drwxr-xr-x /usr/share/locale/ru drwxr-xr-x /usr/share/locale/ru/LC_MESSAGES drwxr-xr-x /usr/share/locale/sr drwxr-xr-x /usr/share/locale/sr/LC_MESSAGES drwxr-xr-x /usr/share/man drwxr-xr-x /usr/share/man/man5 drwxr-xr-x /usr/share/man/man8 drwxr-xr-x /usr/share/pixmaps Additionally, it must not include the files of the paco-debuginfo package, which is generated automatically: drwxr-xr-x /usr/lib/debug drwxr-xr-x /usr/lib/debug/usr drwxr-xr-x /usr/lib/debug/usr/bin drwxr-xr-x /usr/lib/debug/usr/lib * The included pkgconfig file is questionable, since it doesn't include anything really useful/helpful. * Package installs shared libraries into %_libdir, but doesn't run /sbin/ldconfig in %post/%postun scriptlets. * The included *.so library should not be included. * Package must not include static archives (*.a), especially not when there's no API for them. * Package should not include libtool archives (*.la) unless these are really required at run-time. * Package must include the licence file "COPYING" as %doc. * Package should include the files "AUTHORS" and "BUGS" as %doc. * Configuration file ought to be marked as such using %config(noreplace). * Locale message object files must be included with the %find_lang macro and not by including everything below %_datadir. * Desktop menu file could need some love: http://fedoraproject.org/wiki/Packaging/Guidelines * Run-time issues: Desktop menu entry for gpaco doesn't start anything. In terminal, I get: $ gpaco gpaco: /var/log/paco: No such file or directory -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
