Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rogue - text-based adventure game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183097 jpmahowald@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-03-10 00:05 EST ------- Good: - rpmlint checks return: E: rogue non-standard-dir-perm /var/games/roguelike 0775 E: rogue non-standard-executable-perm /usr/bin/rogue 02755 ignored as per comment 1. - package meets naming guidelines - package meets packaging guidelines - license (BSD) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file - runs :) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
