Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: seamonkey https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179802 ------- Additional Comments From caillon@xxxxxxxxxx 2006-03-07 15:52 EST ------- - No need to Require: nss, nspr. RPM will auto generate those requires. - Please use %{?_smp_mflags} instead of -j$CPUS and you can get rid of the relevant getconf calls. - It would be good to get those scripts that rpmlint complained about changed to 0755 instead of 0775. - Also, I think it would be good to try and use %ghost to avoid having to do the rm stuff in %preun - %define _unpackaged_files_terminate_build 0 I just noticed this on. Can you turn that off and make sure it still builds? If there are unpackaged files, you should explicitly rm them, or list them in your %files section with %exclude prepended. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list