Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: muine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180164 ------- Additional Comments From bdpepple@xxxxxxxxxxxxx 2006-03-07 10:44 EST ------- I can't sponser you, but here's a review of your package: MD5Sums: 215dab4b1a0022deadb848b646640514 muine-0.8.4.tar.gz Good: * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * No deprecated fields used * All necessary BuildRequires listed * All desired features are enabled * Make succeeds even when %{_smp_mflags} is defined Bad: * Drop duplicate BuildRequires: gstreamer08-devel (provided by gstreamer08-plugins-devel) * Didn't disable schema installation during build. Refer to http://fedoraproject.org/wiki/ScriptletSnippets#head-ff64cd482595764f672082d5a3b83e1fc22962e8 * Drop the 'killall -HUP gconfd-2 || :' from your scriptlets since it's no longer needed. * rpmlint errors that must be fixed: W: muine incoherent-version-in-changelog yet. 0.8.4-2 W: muine devel-file-in-non-devel-package /usr/lib/pkgconfig/muine-plugin.pc W: muine devel-file-in-non-devel-package /usr/lib/muine/libmuine.a W: muine devel-file-in-non-devel-package /usr/lib/pkgconfig/muine-dbus.pc W: muine devel-file-in-non-devel-package /usr/lib/muine/libinotifyglue.a * I agree with Jeremy in comment #4 that the trayicon should be included with the package. * Drop Requires on gstreamer08, devel pacakge soname pulls this in. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
