Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: OTRS - Open Ticket Request System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180015 mitr@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Additional Comments From mitr@xxxxxxxxxx 2006-03-06 20:59 EST ------- Formal blockers: * The %files section does not specify %defattr * Kernel/cpan-lib seems to be duplicates of separate perl packages, at least some currently in Fedora. Other issues: * scriptlets should properly guard against upgrades, see "Running scriptlets only in certain situations" in PackagingGuidelines * I don't think just installing a package should change the MaxRequestsPerChild option in httpd; does otrs really leak that badly? * Starting httpd: [Tue Mar 07 02:44:25 2006] [warn] Useless use of AllowOverride in line 20. Can this be avoided? * The package seems to install most files world-readable, owned by root; INSTALL.Redhat seems to suggest the permissions should be already configured by the RPM, probably similar to the SetPermissions.sh script. This breaks at least the spell checker: [Tue Mar 07 02:54:14 2006] [error] [Tue Mar 7 02:54:14 2006] -e: Error in tempfile() using /var/www/otrs/var/tmp/XXXXXXXXXX.tmp: Parent directory (/var/www/otrs/var/tmp/) is not writable\n[Tue Mar 7 02:54:14 2006] -e: at /var/www/otrs//Kernel/System/FileTemp.pm line 91\n * The Requires(postun) is not necessary AFAICS * Requires: perl perl-DBI perl-DBD-MySQL is autodetected * I can't see any use of perl-URI from a quick grep * Does the package really require the sendmail program, or just an /usr/sbin/sendmail implementation? * It would be nice if the initscripts used the same way to report success/failure as the other Fedora initscripts (success()/failure()). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list