Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: idioskopos (C++ Introspection Library) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183438 ------- Additional Comments From rvinyard@xxxxxxxxxxx 2006-03-06 02:03 EST ------- How embarrassing to have such a simple error in the example code labelled 'simple'; and that after the state that configure.in was in. At least on this one I can claim that GCC-4.0 passed it, even though good style would have demanded that it never be there. Ralf, I never intended for you to end up a code reviewer, but I sincerely appreciate the items you've pointed out. Anyway, I've pushed a new release with the fixed example code. I've made a few changes to the spec (replacing ${RPM_BUILD_ROOT} with %{buildroot}, make with %{__make}, and rm with %{__rm}). I've double and triple checked it to ensure that I didn't introduce any new errors to ensure that this is the last time you have to look at this package. Thanks again, and hopefully for the last time, here are the files: Spec Name or Url: http://miskatonic.cs.nmsu.edu/pub/idioskopos.spec SRPM Name or Url: http://miskatonic.cs.nmsu.edu/pub/fedora/4/srpms/idioskopos-0.1.10-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
